Make wording "Unlock file manually" translatable #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerome-Herbinet
requested review from
juliusknorr and
max-nextcloud
as code owners
Jerome-Herbinet
added
bug
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Make wording "Unlock file manually" translatable Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-make-unlock-file-manually-translatable
branch
from
473eeac to
47aabbb
Compare
juliusknorr
reviewed
Oct 24, 2025
|
|
||
| if (lock?.lockOwnerType === LockType.Token) { | ||
| const dialog = getDialogBuilder('Unlock file manually') | ||
| const dialog = getDialogBuilder('files_lock', 'Unlock file manually') |
There was a problem hiding this comment.
Suggested change
| const dialog = getDialogBuilder('files_lock', 'Unlock file manually') | |
| const dialog = getDialogBuilder(t('files_lock', 'Unlock file manually')) |
There was a problem hiding this comment.
Thanks, it needs a further adjustment to call the translate function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping the syntax has no issue.
Test from reviewers needed.