Skip to content

fix: Hide empty inline menu entry in grid view #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Mar 18, 2025
Merged

fix: Hide empty inline menu entry in grid view #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
import { getCurrentUser } from '@nextcloud/auth'

import '@nextcloud/dialogs/style.css'
import './styles.css'

import LockSvg from '@mdi/svg/svg/lock.svg?raw'
import LockOpenSvg from '@mdi/svg/svg/lock-open-variant.svg?raw'
Expand Down Expand Up @@ -97,6 +98,7 @@ const inlineAction = new FileAction({

// FIXME: Currently enabled is not re-evaluated when emitting an updated node object through files:node:updated
// Therefor we need to also have a unlocked state as the inline action is then always rendered
// We currently hide them for the grid view via css
return true

const node = nodes[0]
Expand Down
10 changes: 10 additions & 0 deletions src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/**
* SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

/* The grid view currently does not properly handle inline actions, we hide them for now */
.action-item__popper .action.files-list__row-action-lock_inline,
.files-list--grid .action.files-list__row-action-lock_inline {
display: none;
}
Loading