Skip to content

fix: keep track of download count #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

fix: keep track of download count #510

merged 1 commit into from
Aug 28, 2025

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Aug 25, 2025 •
edited
Loading

fix #501

implemented #501 (comment) which worked like a charm

@hamza221 hamza221 requested review from artonge and come-nc August 25, 2025 21:41
@hamza221 hamza221 self-assigned this Aug 25, 2025
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels Aug 25, 2025
@hamza221
Copy link
Contributor Author

/backport to stable31

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Aug 25, 2025
@hamza221
Copy link
Contributor Author

/backport to stable30

come-nc
come-nc reviewed Aug 26, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Did not test zip download.

The video range request handling is missing.
Also the application had no release in a long time, we should publish it after this fix. An openapi file would also be good as there is no UI to set limits.

@hamza221
Copy link
Contributor Author

hamza221 commented Aug 26, 2025 •
edited
Loading

as

Ui exits, but there's a bug and its unusable atm
edit: fyi nextcloud-libraries/nextcloud-vue#6607 (comment)

@hamza221
fix: keep track of download count
9db2207 
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 merged commit ef966f9 into master Aug 28, 2025
23 checks passed
@hamza221 hamza221 deleted the fix/counter branch August 28, 2025 11:09
This was referenced Aug 28, 2025
Merged
Merged
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Aug 28, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@hamza221 hamza221

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

File Download limit not decreasing

3 participants

@hamza221 @come-nc