Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add js test workflow #856

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jan 9, 2025

No description provided.

@artonge artonge added the 3. to review Waiting for reviews label Jan 9, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 9, 2025
@artonge artonge requested a review from skjnldsv January 9, 2025 11:04
@artonge artonge self-assigned this Jan 9, 2025
@artonge artonge force-pushed the artonge/feat/js_test_workflow branch 6 times, most recently from 96738a8 to 0b84b07 Compare January 9, 2025 11:28
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.09%. Comparing base (ed6a195) to head (e8a9750).
Report is 719 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #856       +/-   ##
=============================================
- Coverage     93.57%   22.09%   -71.49%     
=============================================
  Files             3       29       +26     
  Lines           109     1249     +1140     
  Branches          0       26       +26     
=============================================
+ Hits            102      276      +174     
- Misses            7      971      +964     
- Partials          0        2        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artonge
Copy link
Collaborator Author

artonge commented Jan 9, 2025

/compile amend /

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the artonge/feat/js_test_workflow branch from 0b84b07 to e8a9750 Compare January 9, 2025 16:35
@artonge artonge merged commit c11ecc3 into master Jan 9, 2025
43 checks passed
@artonge artonge deleted the artonge/feat/js_test_workflow branch January 9, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants