feat: Support more types of mnemonics #855
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
3. to review
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
25c43be to
3704510
Compare
artonge
force-pushed
the
artonge/feat/support_more_mneomonic
branch
from
3aa9cf0 to
3fc7f13
Compare
skjnldsv
approved these changes
Jan 9, 2025
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
3704510 to
51f8f44
Compare
artonge
force-pushed
the
artonge/feat/support_more_mneomonic
branch
from
3fc7f13 to
37551bf
Compare
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
2 times, most recently
from
5584e77 to
1bd3dd4
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/feat/support_more_mneomonic
branch
from
37551bf to
b6a7c27
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## artonge/feat/validate_user_public_keys #855 +/- ##
==========================================================================
+ Coverage 25.73% 26.18% +0.44%
==========================================================================
Files 30 30
Lines 1321 1333 +12
Branches 32 37 +5
==========================================================================
+ Hits 340 349 +9
- Misses 978 981 +3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other clients moved to a more secure hash and iteration count, so we need to accept those.