-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validate signature of users' certificate in metadata #852
Open
artonge
wants to merge
2
commits into
master
Choose a base branch
from
artonge/feat/validate_user_public_keys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+688
−694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
3. to review
Waiting for reviews
enhancement
New feature or request
javascript
Javascript related ticket
labels
Jan 7, 2025
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
January 7, 2025 12:36
b4209d0
to
7909fac
Compare
5 tasks
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
January 7, 2025 13:39
7909fac
to
1304832
Compare
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
January 8, 2025 16:46
1304832
to
2b3b907
Compare
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
January 8, 2025 16:51
2b3b907
to
25c43be
Compare
artonge
force-pushed
the
artonge/chore/cleanups
branch
from
January 8, 2025 16:52
edadda8
to
7770073
Compare
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
2 times, most recently
from
January 9, 2025 09:40
3704510
to
51f8f44
Compare
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
January 9, 2025 10:38
51f8f44
to
b8169d3
Compare
/compile / |
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
January 9, 2025 17:06
5584e77
to
1bd3dd4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 22.23% 25.73% +3.50%
==========================================
Files 29 30 +1
Lines 1255 1321 +66
Branches 27 32 +5
==========================================
+ Hits 279 340 +61
- Misses 973 978 +5
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
New feature or request
javascript
Javascript related ticket
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that the users' certificates are signed by the server's private key