Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate signature of users' certificate in metadata #852

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jan 7, 2025

Validate that the users' certificates are signed by the server's private key

@artonge artonge added 3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket labels Jan 7, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 7, 2025
@artonge artonge self-assigned this Jan 7, 2025
@artonge artonge force-pushed the artonge/feat/validate_user_public_keys branch from b4209d0 to 7909fac Compare January 7, 2025 12:36
@artonge artonge force-pushed the artonge/feat/validate_user_public_keys branch from 7909fac to 1304832 Compare January 7, 2025 13:39
@artonge artonge requested review from nfebe and skjnldsv January 7, 2025 13:46
@artonge artonge force-pushed the artonge/feat/validate_user_public_keys branch from 1304832 to 2b3b907 Compare January 8, 2025 16:46
@artonge artonge changed the base branch from master to artonge/chore/cleanups January 8, 2025 16:48
@artonge artonge force-pushed the artonge/feat/validate_user_public_keys branch from 2b3b907 to 25c43be Compare January 8, 2025 16:51
@artonge artonge force-pushed the artonge/chore/cleanups branch from edadda8 to 7770073 Compare January 8, 2025 16:52
@artonge artonge force-pushed the artonge/feat/validate_user_public_keys branch 2 times, most recently from 3704510 to 51f8f44 Compare January 9, 2025 09:40
Base automatically changed from artonge/chore/cleanups to master January 9, 2025 09:47
@artonge artonge force-pushed the artonge/feat/validate_user_public_keys branch from 51f8f44 to b8169d3 Compare January 9, 2025 10:38
@artonge
Copy link
Collaborator Author

artonge commented Jan 9, 2025

/compile /

artonge and others added 2 commits January 9, 2025 18:04
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge force-pushed the artonge/feat/validate_user_public_keys branch from 5584e77 to 1bd3dd4 Compare January 9, 2025 17:06
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 81.01266% with 15 lines in your changes missing coverage. Please review.

Project coverage is 25.73%. Comparing base (87441cd) to head (1bd3dd4).

Files with missing lines Patch % Lines
src/services/webDavProxy.ts 10.00% 9 Missing ⚠️
src/services/api.ts 76.92% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
+ Coverage   22.23%   25.73%   +3.50%     
==========================================
  Files          29       30       +1     
  Lines        1255     1321      +66     
  Branches       27       32       +5     
==========================================
+ Hits          279      340      +61     
- Misses        973      978       +5     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants