Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Oct 20, 2025

  • Update dependencies
  • Migrate code where needed to new Vue 3 API
  • manual tested that the app still works

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 23.07692% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.94%. Comparing base (d8a0531) to head (675df6e).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/components/SecuritySection.vue 0.00% 9 Missing ⚠️
src/components/AdminSection.vue 0.00% 6 Missing ⚠️
src/settings-admin.ts 0.00% 4 Missing ⚠️
src/settings-user.ts 0.00% 4 Missing ⚠️
src/main-filedrop.ts 0.00% 3 Missing ⚠️
src/views/FileDrop.vue 0.00% 3 Missing ⚠️
src/services/mnemonicDialogs.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
- Coverage   34.35%   32.94%   -1.42%     
==========================================
  Files          24       24              
  Lines        1307     1442     +135     
  Branches       48       48              
==========================================
+ Hits          449      475      +26     
- Misses        856      966     +110     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added 3. to review Waiting for reviews enhancement New feature or request labels Oct 21, 2025
@susnux susnux marked this pull request as ready for review October 21, 2025 11:09
@susnux susnux requested a review from artonge October 21, 2025 11:09
@susnux
Copy link
Contributor Author

susnux commented Oct 21, 2025

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 1cd8aa3 into master Oct 21, 2025
39 of 42 checks passed
@susnux susnux deleted the feat/vue3 branch October 21, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants