bug: Deleting multiple files from the web fails

[artonge]

The web UI tries to lock the folder for every delete operation, this fails if a delete is already ongoing.

We should probably reuse the existing lock token.
We should also store whether a lock is being requested as some requests are failing due to a DB duplicate constraint error.

This is probably an issue for other operations.

Request flow when deleting 5 files simultanously:

500 error:

403 error:

cc @susnux

[susnux]

well we only intercept on per-request basis, so the problem here is we do not know about other requests.

Was this a batch operation in the files app? Then we probably should add our own delete action.
But this would only fix this one case...

Maybe its better to add some kind of locking store and wait for other requests to finish first.
I will have a look.

[artonge]

so the problem here is we do not know about other requests.

We can know about ongoing requests and whether we have a lock token.

Maybe its better to add some kind of locking store and wait for other requests to finish first.

I think: yes and then no.

Yes, we should have a locking store, but this store should be used to store lock token, and whether a request is using it or not.

token1 = await lockStore.lock(folderId); // This will request a token
token2 = await lockStore.lock(folderId); // This will reuse the same token

token1 === token2 // true

await lockStore.unlock(folderId, token1); // This won't actually unlock the folder as the token is still used
await lockStore.unlock(folderId, token2); // This will now unlock the folder.

Then somthing close to:

// store/lock.ts

const locks = {}
const tokens = {}

export function lock(folderId: number): string {
	if (locks[folderId] !== undefined) {
		const token = locks[folderId]
		tokens[token]++
		return token
	} else {
		const token = api.lockFolder(folderId)
		locks[folderId] = token
		tokens[token] = 1
		return token
	}
}

export function unlock(folderId: number, token: string) {
	tokens[token]--
	if (tokens[token] === 0) {
		api.unlockFolder(folderId, token)
		delete locks[folderId]
		delete tokens[token]
	}
}

[susnux]

Looks good but will have to check if that works.
Because if we not lock the root then this will fail if you try to lock some folder in the same root.