feat(dev-manual): Document performance optimizations with class loaders#9573
Merged
juliusknorr merged 1 commit intomasterfrom Jan 20, 2023
Merged
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2 tasks
Member
|
wow. very interesting. This filesystem finds can generate a lot of IOPs which can cause bigger slowdowns especially when Nextcloud is stored in a remove network filesystem. |
juliusknorr
approved these changes
Jan 20, 2023
Member
Author
|
/backport to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature was added with nextcloud/server#6853 a while ago for shipped apps in the server repo but has not gained much popularity. I assume it's because nobody knew or profiled the difference.
Thanks to Blackfire profiles I saw warnings that Composer still had to find hundreds of files, even if apps had an automated autoloader. My theory: Nextcloud registered its own loader before the app loader is there. So the app loader doesn't even get a chance. Effectively, app loader would only be used for app dependencies.
Benchmarks
As a positive side effect, replacing the server class loader not only disables the PSR-4 loader but also the PSR-0. We know that this gives a significant boost for Nextcloud processes: nextcloud/server#36114 #9553.
Preview