- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.2k
Add documentation for cache control immutable #8027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See https://github.com/nextcloud/server/pull/31141/files Signed-off-by: Carl Schwan <carl@carlschwan.eu>
318adbd    to
    b30299c      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, doesn't break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
| This didn't work for me. Adding the directive resulted in 404s for urls like  This is a pretty vanilla setup, using docker and  | 
| 
 Thanks for the feedback, I will look into ut tomorrow | 
| Did some more testing and I can reproduce, I think I placed the block in a different place when testing initially 🙈 Adding the  | 
| This is a general "issue" with Nginx, not all directives present in the parent location block are inherited. AFAIK this affects  Are there actually assets without versioned query string? Otherwise we could just merge it by appending  Also, what is actually the reason for using just 7 days caching for fonts? Couldn't they be merged with the other assets? | 
See nextcloud/server#31141
I didn't test it, can an nginx expert try to see if the syntax is correct?
Signed-off-by: Carl Schwan carl@carlschwan.eu