Skip to content

Conversation

@dassio
Copy link
Contributor

@dassio dassio commented Oct 4, 2020

Signed-off-by: dassio dassio@icloud.com

during development, migration can be changed multiple times, using the updating version tag method to trigger migration has the following drawbacks:

  1. version number has to be increased multi times when only one feature is added
  2. wrong migration has to be deleted from the oc_migrations table manually, or the server will complain same migration already be used

the migration command does not have that constraint, just drop the table and run sudo -u www-data php ./occ migrations:execute photos 000000Date20201002183800 will recreate the table for you.

@dassio dassio requested a review from juliusknorr October 4, 2020 09:11
dassio added 2 commits October 4, 2020 17:11
Signed-off-by: dassio <dassio@icloud.com>
Signed-off-by: dassio <dassio@icloud.com>
`````````````

The name should reflect the subject and the actions. Prefixing event classes with `Event` makes it easier to recognize their purpose.
The name should reflect the subject and the actions. Suffixing event classes with `Event` makes it easier to recognize their purpose.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to your actual PR's topic but 👍 on this one

@ChristophWurst
Copy link
Member

Mind submitting 097b700 on a separate branch/PR to keep things a bit separate? ✌️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me with the two separate commits.

@MorrisJobke MorrisJobke merged commit 8752c1d into nextcloud:master Oct 6, 2020
@MorrisJobke
Copy link
Member

/backport to stable20

@MorrisJobke
Copy link
Member

/backport to stable19

@MorrisJobke
Copy link
Member

/backport to stable18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants