Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(primary+external storage) S3 bucket naming requirements #10603

Merged
merged 1 commit into from
Jun 12, 2023
Merged

(primary+external storage) S3 bucket naming requirements #10603

merged 1 commit into from
Jun 12, 2023

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jun 10, 2023 •
edited
Loading

  • Adds note about S3 bucket naming requirements needing to be compliant with AWS S3 rules even if using a third-party S3 provider/platform (in order to work with the aws-sdk-php we use).
  • Adds note about S3 endpoint usage for hostname to External Storage doc (to be consistent with Primary Storage doc change recently made in (Primary Storage) Generic S3 endpoint for hostname  #10595)

☑️ Resolves

🖼️ Screenshots

@joshtrichards
(primary+external storage) S3 bucket naming requirements
f31ca31 
Fixes nextcloud/server#35364

Also adds note about S3 endpoint naming to to External Storage make consistent with Primary Storage change made in nextcloud#10595

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards joshtrichards mentioned this pull request Jun 10, 2023
Closed
9 tasks
@szaimen szaimen added this to the Nextcloud 28 milestone Jun 10, 2023
artonge
artonge approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@juliushaertl juliushaertl merged commit 7dfadec into nextcloud:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: "Call to a member function getType() on bool" on External Storage
4 participants
@joshtrichards @artonge @juliushaertl @szaimen