Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggering install and update script #1181

Merged
merged 2 commits into from
Jul 26, 2020
Merged

Conversation

stackcoder
Copy link
Contributor

The default commands set in Dockerfile, entrypoint.sh and README.me were out of sync. Therefore, the install and update script was not trigger at initial startup unless NEXTCLOUD_UPDATE=1 were set.

Signed-off-by: stackcoder <stackcoder@gmail.com>
Signed-off-by: stackcoder <stackcoder@gmail.com>
Copy link
Contributor

@J0WI J0WI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J0WI J0WI merged commit de90bed into nextcloud:master Jul 26, 2020
@tilosp
Copy link
Member

tilosp commented Jul 27, 2020

@J0WI @stackcoder i don't see how the regex apache2-foreground matches something that the regex apache couldn’t.

I personally like the more generally approach of using the regex to ignore the apache major version.
But even if we want to match on the exact command it makes no sense to use a regex.

So this should be either reverted or we replace the reqex matching with a simply string comparison like we already do for php-fpm.

J0WI added a commit to J0WI/docker-nextcloud that referenced this pull request Jul 28, 2020
tilosp added a commit that referenced this pull request Jul 28, 2020
Revert "Fix triggering install and update script (#1181)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants