Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
168 commits
Select commit Hold shift + click to select a range
6613490
feat: move settings navigation to left sidebar
Rello Jan 13, 2026
7f24ac2
Merge pull request #9302 from Rello/codex/rebuild-settings-screen-wit…
Rello Jan 13, 2026
5172072
Update FileProviderSettings.qml
Rello Jan 13, 2026
d4c44c2
feat: refine settings sidebar layout
Rello Jan 13, 2026
6485420
Update owncloudgui.h
Rello Jan 13, 2026
bbbfa0a
Adjust toolbar button padding and add spacer
Rello Jan 13, 2026
45b7a29
Add macOS specific stylesheet for tab widget
Rello Jan 13, 2026
57b880c
feat: soften settings dialog visuals
Rello Jan 13, 2026
52e6180
feat: add settings panel styling
Rello Jan 13, 2026
168b060
Merge branch 'feature/settingsLayout' into codex/rebuild-settings-scr…
Rello Jan 13, 2026
8d0f758
fix: adjust settings dialog layout
Rello Jan 14, 2026
f3c2e34
Merge pull request #20 from Rello/codex/update-settings-window-layout
Rello Jan 14, 2026
89fe819
Merge pull request #9313 from Rello/codex/rebuild-settings-screen-wit…
Rello Jan 14, 2026
1cf771d
fix: adjust tray spacing and account highlight
Rello Jan 14, 2026
b75970e
Merge pull request #21 from Rello/codex/adjust-content-spacing-and-st…
Rello Jan 14, 2026
96e5336
Merge pull request #9314 from Rello/codex/rebuild-settings-screen-wit…
Rello Jan 14, 2026
21b9447
Revert "Codex/rebuild settings screen with left menu"
Rello Jan 14, 2026
c3cb2da
Merge pull request #9315 from nextcloud/revert-9314-codex/rebuild-set…
Rello Jan 14, 2026
d8250b6
Revert "fix: tighten tray spacing and blue account selection highlight"
Rello Jan 14, 2026
06d9d82
Merge pull request #22 from Rello/revert-21-codex/adjust-content-spac…
Rello Jan 14, 2026
06a9814
Update settingsdialog.cpp
Rello Jan 14, 2026
db40331
Update settingsdialog.cpp
Rello Jan 14, 2026
952061c
make the standard sync settings box background transparent
Rello Jan 14, 2026
47c6670
get settings headers out of the panel in the general settings
Rello Jan 14, 2026
636d281
Remove title styling from settings dialog group boxes
Rello Jan 14, 2026
2e192a3
fix: align account tab pane background
Rello Jan 15, 2026
c166ef6
Merge pull request #23 from Rello/codex/locate-background-color-setti…
Rello Jan 15, 2026
713e5f1
fix: move settings titles above panels
Rello Jan 15, 2026
e6f2f93
Merge pull request #24 from Rello/codex/update-settings-dialog-for-ma…
Rello Jan 15, 2026
388c09e
dark mode
Rello Jan 15, 2026
8bdddf9
transparent background color of folder list
Rello Jan 15, 2026
03022d2
Refactor FileProviderSettings layout with RowLayout
Rello Jan 15, 2026
1de0fc8
fix missing {}
Rello Jan 15, 2026
3f64103
Update generalsettings.ui
Rello Jan 15, 2026
5bd9b2b
Update generalsettings.ui
Rello Jan 15, 2026
ef4eb5f
Refactor FileProviderSettings layout with RowLayout
Rello Jan 15, 2026
4c3e008
Refactor SettingsDialog stylesheet for consistency
Rello Jan 15, 2026
ba6d9b3
wordWrap for E2E string
Rello Jan 15, 2026
d469ae2
dark mode
Rello Jan 15, 2026
d41ea0e
dark mode
Rello Jan 15, 2026
673ddc3
reduce margins
Rello Jan 15, 2026
e468e0b
dark mode correction
Rello Jan 15, 2026
7e2d3a0
fix: restore settings dialog background separation
Rello Jan 15, 2026
adcdcc6
Merge pull request #25 from Rello/codex/fix-dark-mode-in-settings-dialog
Rello Jan 15, 2026
9576f51
remove storage panel
Rello Jan 15, 2026
62d5efc
remove storage panel
Rello Jan 15, 2026
ed7351c
change E2E buttons
Rello Jan 15, 2026
e2db464
fix: align storage usage and e2e buttons
Rello Jan 15, 2026
7491458
Merge pull request #26 from Rello/codex/refactor-settings-layout-and-…
Rello Jan 15, 2026
edf8ad9
Add applyEncryptionMessageButtonStyle method
Rello Jan 16, 2026
7538939
Merge branch 'codex/rebuild-settings-screen-with-left-menu' into feat…
Rello Jan 16, 2026
30ba6b9
Merge pull request #27 from nextcloud/feature/settingsV2
Rello Jan 16, 2026
8e97706
Update settingsdialog.cpp
Rello Jan 16, 2026
65d96e5
E2E remove frame
Rello Jan 16, 2026
168bab8
E2E remove frame
Rello Jan 16, 2026
cc9f137
missing }
Rello Jan 16, 2026
79562a6
fix: separate settings panel colors
Rello Jan 16, 2026
a738b80
Merge pull request #28 from Rello/codex/add-mode-dependent-panel-colo…
Rello Jan 16, 2026
54fe022
fix: align e2e message styling
Rello Jan 16, 2026
76ba8c1
Merge pull request #29 from Rello/codex/update-e2e-button-style-and-l…
Rello Jan 16, 2026
dd50f71
Update FileProviderSettings.qml
Rello Jan 16, 2026
d72196e
margin typo
Rello Jan 16, 2026
4ff81c5
margin typo
Rello Jan 16, 2026
e58ddc3
active indicator margins
Rello Jan 16, 2026
2cd7b7f
fix: reduce settings nav active indicator padding
Rello Jan 16, 2026
61a4d7a
Merge pull request #30 from Rello/codex/reduce-padding-of-active-indi…
Rello Jan 16, 2026
1cb8174
scrolling for settings dialog
Rello Jan 16, 2026
99fc709
fix: add independent scrolling to settings dialog
Rello Jan 16, 2026
3ee3521
Merge pull request #31 from Rello/codex/reduce-settings-dialog-height…
Rello Jan 16, 2026
51c8f48
color & style adjustment
Rello Jan 17, 2026
5d5b005
default settings size
Rello Jan 17, 2026
3ed50cd
fix scrolling
Rello Jan 17, 2026
d4274f7
Account settings reduce top margin
Rello Jan 17, 2026
6b4471d
fix: brighten settings window without panel shift
Rello Jan 17, 2026
ab5282a
Merge pull request #32 from Rello/codex/fix-dynamic-height-issues-in-…
Rello Jan 17, 2026
154c61b
fix: align settings panels
Rello Jan 17, 2026
a534f70
Merge pull request #33 from Rello/codex/align-account-status-and-navi…
Rello Jan 17, 2026
0168a56
no outer padding in account settings
Rello Jan 18, 2026
c835ee4
general settings headings inside panel
Rello Jan 18, 2026
20c6c34
reduce margins in general settings
Rello Jan 18, 2026
67e502f
fix: refine settings layout spacing
Rello Jan 18, 2026
c0cae5c
Merge pull request #34 from Rello/codex/fix-navigation-item-content-j…
Rello Jan 18, 2026
c7fcda1
refactor: simplify settings dialog layout styling
Rello Jan 18, 2026
29ab5b8
scroll backgrounds to transparent
Rello Jan 18, 2026
5f4e8a5
account status margins
Rello Jan 18, 2026
a27d06e
fix: remove account status layout margins
Rello Jan 18, 2026
bfe114a
avatarsk
Rello Jan 18, 2026
70a49a1
refactor: reuse avatar update logic
Rello Jan 18, 2026
c61f418
avatars in settings navigation
Rello Jan 18, 2026
962620e
Merge pull request #35 from Rello/codex/simplify-settings-dialog-stru…
Rello Jan 18, 2026
2e0b505
Merge pull request #36 from Rello/codex/remove-margins-from-accountst…
Rello Jan 18, 2026
6ecde77
Merge pull request #37 from Rello/codex/fix-avatar-display-in-account…
Rello Jan 18, 2026
9421c9d
missing constant in avatar function
Rello Jan 18, 2026
d304128
missing constant
Rello Jan 18, 2026
19edc04
set styles to standard pallets to fix dark/light mode
Rello Jan 19, 2026
4d152f9
fileprovider background color
Rello Jan 19, 2026
e4278bd
dark/light switcher colors
Rello Jan 19, 2026
d21239d
scroll -> widget -> background false
Rello Jan 19, 2026
d05dc01
background to navigation scroll widget
Rello Jan 19, 2026
f492814
navigation scroll background
Rello Jan 19, 2026
3c39cd8
background in settings tabs
Rello Jan 19, 2026
54608b6
fix: align account settings tab backgrounds
Rello Jan 19, 2026
678cb59
navigation viewport color
Rello Jan 19, 2026
75e42ca
Merge pull request #38 from Rello/codex/locate-#accounttabspanel-cont…
Rello Jan 19, 2026
33fdead
navigation background
Rello Jan 20, 2026
907b442
navigation hover
Rello Jan 20, 2026
2990c76
Merge branch 'codex/rebuild-settings-screen-with-left-menu' into feat…
Rello Jan 20, 2026
aecab33
fileprovider settings to panel
Rello Jan 20, 2026
6f9dab9
fileprovider to panel
Rello Jan 20, 2026
3202f7d
folder list background
Rello Jan 20, 2026
3c41b78
fileprovider to panel
Rello Jan 20, 2026
a932b88
fileprovider to panel
Rello Jan 20, 2026
8a9c9f1
network settings background
Rello Jan 20, 2026
e0390c3
navigation background
Rello Jan 20, 2026
16d45f0
navigation background still wrong
Rello Jan 20, 2026
2902c3f
VFS box remove 0 margins
Rello Jan 20, 2026
2c9a642
VFS sizing to panel
Rello Jan 20, 2026
de723ba
panel resizing
Rello Jan 20, 2026
822401e
report minimus size to parent object
Rello Jan 20, 2026
2c7bc27
fix: size sync folders panel to contents
Rello Jan 20, 2026
daba653
Merge pull request #9343 from nextcloud/codex/make-sync-folder-box-dy…
Rello Jan 20, 2026
c50eae9
layout fix
Rello Jan 21, 2026
81c50b1
layout fix
Rello Jan 21, 2026
c58a35e
layout fix
Rello Jan 21, 2026
ca03317
panel design also for the folder sync box
Rello Jan 21, 2026
c992deb
network settings without tab
Rello Jan 21, 2026
2e11db4
network settings without tabs
Rello Jan 21, 2026
cce40ea
network settings without tabs
Rello Jan 21, 2026
51fcb49
proxy setting margin
Rello Jan 21, 2026
fec45ed
general settings spacing
Rello Jan 21, 2026
bed299e
Remove vertical spacer from network settings UI
Rello Jan 21, 2026
68a3650
connection panel margins
Rello Jan 21, 2026
0339259
revert general settings spacing issue
Rello Jan 21, 2026
d389e37
Merge branch 'feature/settingsV2' into settingsV2Update
Rello Jan 22, 2026
991d4e7
Merge pull request #9361 from nextcloud/settingsV2Update
Rello Jan 22, 2026
f7e9fd5
resize panels on content switching
Rello Jan 22, 2026
700066e
content dynamic sizing
Rello Jan 22, 2026
02e3696
chore: fix compilation by removing unused variables
mgallien Jan 26, 2026
a713c19
navigation background
Rello Jan 27, 2026
0c6a268
navigation background
Rello Jan 27, 2026
623bf4e
account spacing
Rello Jan 27, 2026
9b97d8d
Update accountsettings.ui
Rello Jan 27, 2026
a6ceb05
VFS spacing
Rello Jan 28, 2026
fa9eb68
network settings spacing
Rello Jan 28, 2026
a959534
no E2E frame
Rello Jan 28, 2026
fe115f3
remove non working VFS resizing
Rello Jan 28, 2026
36f56bc
VFS remove trash setting
Rello Jan 28, 2026
74eb659
reset E2E changes
Rello Jan 28, 2026
71405d8
Remove applyEncryptionMessageFrameStyle method
Rello Jan 28, 2026
73e4401
Remove applyEncryptionMessageButtonStyle method
Rello Jan 28, 2026
02e27ea
Remove applyEncryptionMessageButtonStyle function
Rello Jan 28, 2026
46e129c
refactor: replace e2e notice with widget layout
Rello Jan 30, 2026
7e756f4
Merge pull request #9394 from nextcloud/codex/find-source-of-e2e-sett…
Rello Jan 30, 2026
6ef181d
fix: avoid extra space in sync folders panel
Rello Jan 30, 2026
c67f6ea
Merge pull request #9396 from nextcloud/codex/remove-extra-space-in-s…
Rello Jan 30, 2026
b03c53c
Merge branch 'master' into feature/settingsV2
Rello Feb 3, 2026
c1e7424
Merge branch 'master' into feature/settingsV2
Rello Feb 4, 2026
f669a16
stretch the VFS settings to full width
Rello Feb 4, 2026
90ca827
remove space below sync setup button
Rello Feb 4, 2026
61e3793
Fix E2E content padding in account settings
Rello Feb 4, 2026
74122ba
Update E2E button style
Rello Feb 4, 2026
7c8ffb5
Uniform spacing for connection settings boxes
Rello Feb 4, 2026
87479e2
E2E button layout fix
Rello Feb 5, 2026
86b39c0
Change QQuickWidget size policy option
Rello Feb 5, 2026
bddd475
Clean up quota progress bar implementation
Rello Feb 5, 2026
b996647
Add _spaceUsageText member to AccountSettings
Rello Feb 5, 2026
1872d0e
Remove storage group box layout from account settings
Rello Feb 5, 2026
641cb22
Refactor sizeHint method for better readability
Rello Feb 5, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/3rdparty/kmessagewidget/kmessagewidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -496,4 +496,3 @@ void KMessageWidget::setIcon(const QIcon &icon)
}

#include "moc_kmessagewidget.cpp"

2 changes: 2 additions & 0 deletions src/3rdparty/kmessagewidget/kmessagewidget.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#ifndef KMESSAGEWIDGET_H
#define KMESSAGEWIDGET_H

#include <QFrame>

Check failure on line 11 in src/3rdparty/kmessagewidget/kmessagewidget.h

View workflow job for this annotation

GitHub Actions / build

src/3rdparty/kmessagewidget/kmessagewidget.h:11:10 [clang-diagnostic-error]

'QFrame' file not found

class KMessageWidgetPrivate;

Expand Down Expand Up @@ -153,6 +153,7 @@
*/
[[nodiscard]] MessageType messageType() const;


/**
* Add @p action to the message widget.
* For each action a button is added to the message widget in the
Expand All @@ -171,6 +172,7 @@
*/
void removeAction(QAction *action);


/**
* Returns the preferred size of the message widget.
*/
Expand Down
200 changes: 130 additions & 70 deletions src/gui/accountsettings.cpp

Large diffs are not rendered by default.

15 changes: 14 additions & 1 deletion src/gui/accountsettings.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/*
* SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
* SPDX-FileCopyrightText: 2014 ownCloud GmbH
Expand All @@ -7,7 +7,7 @@
#ifndef ACCOUNTSETTINGS_H
#define ACCOUNTSETTINGS_H

#include <QWidget>

Check failure on line 10 in src/gui/accountsettings.h

View workflow job for this annotation

GitHub Actions / build

src/gui/accountsettings.h:10:10 [clang-diagnostic-error]

'QWidget' file not found
#include <QUrl>
#include <QPointer>
#include <QHash>
Expand All @@ -27,6 +27,8 @@
class QNetworkReply;
class QListWidgetItem;
class QLabel;
class QPushButton;

Check warning on line 30 in src/gui/accountsettings.h

View workflow job for this annotation

GitHub Actions / build

src/gui/accountsettings.h:30:7 [cppcoreguidelines-avoid-non-const-global-variables]

variable 'QPushButton' is non-const and globally accessible, consider making it const
class QIcon;

Check warning on line 31 in src/gui/accountsettings.h

View workflow job for this annotation

GitHub Actions / build

src/gui/accountsettings.h:31:7 [cppcoreguidelines-avoid-non-const-global-variables]

variable 'QIcon' is non-const and globally accessible, consider making it const

namespace OCC {

Expand All @@ -52,7 +54,13 @@
public:
explicit AccountSettings(AccountState *accountState, QWidget *parent = nullptr);
~AccountSettings() override;
[[nodiscard]] QSize sizeHint() const override { return ownCloudGui::settingsDialogSize(); }
[[nodiscard]] QSize sizeHint() const override
{
return {
ownCloudGui::settingsDialogSize().width(),
QWidget::sizeHint().height()
};
}
bool canEncryptOrDecrypt(const FolderStatusModel::SubFolderInfo* folderInfo);
[[nodiscard]] OCC::AccountState *accountsState() const { return _accountState; }

Expand Down Expand Up @@ -132,6 +140,8 @@
QAction *addActionToEncryptionMessage(const QString &actionTitle, const QString &actionId);

void setupE2eEncryptionMessage();
void setEncryptionMessageIcon(const QIcon &icon);
void updateEncryptionMessageActions();

/// Returns the alias of the selected folder, empty string if none
[[nodiscard]] QString selectedFolderAlias() const;
Expand All @@ -149,6 +159,9 @@
bool _menuShown = false;

QHash<QString, QMetaObject::Connection> _folderConnections;
QHash<QAction *, QPushButton *> _encryptionMessageButtons;

QString _spaceUsageText;
};

} // namespace OCC
Expand Down
Loading
Loading