refactor: replace e2e notice with widget layout#9394
Merged
Rello merged 1 commit intofeature/settingsV2from Jan 30, 2026
Merged
refactor: replace e2e notice with widget layout#9394Rello merged 1 commit intofeature/settingsV2from
Rello merged 1 commit intofeature/settingsV2from
Conversation
Collaborator
Author
|
internal test PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
KMessageWidgetwith a colored background which made it visually inconsistent with other account settings controls.QWidgetlayout with icon, text and actions.KMessageWidgetand instead drive the notice presentation directly from the Account Settings UI.Description
KMessageWidgetinstance insrc/gui/accountsettings.uiwith a plainQWidgetcontaining an iconQLabel, a textQLabeland a horizontal layout for action buttons.src/gui/accountsettings.cppto set the notice text via_ui->encryptionMessageLabel, set the icon viasetEncryptionMessageIcon(), and rebuild action buttons withupdateEncryptionMessageActions()usingQToolButtons wired toQActions.src/gui/accountsettings.h:setEncryptionMessageIcon()andupdateEncryptionMessageActions()and aQHash<QAction *, QToolButton *> _encryptionMessageButtonsto track created buttons.useColoredBackgroundAPI fromsrc/3rdparty/kmessagewidget/kmessagewidget.h/.cpp(restoring normalKMessageWidgetinterface/behavior) and cleaned up related styling changes, leavingKMessageWidgetunchanged behavior-wise for other usages.KMessageWidgettext/icon/methods were referenced to use the new label/icon/button layout instead.Testing
Codex Task