Skip to content

[stable-3.17] fix(migration): set all settings and keychain keys from the previous version of the client.#9101

Merged
mgallien merged 15 commits intostable-3.17from
backport/8969/stable-3.17
Nov 18, 2025
Merged

[stable-3.17] fix(migration): set all settings and keychain keys from the previous version of the client.#9101
mgallien merged 15 commits intostable-3.17from
backport/8969/stable-3.17

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Nov 18, 2025

Backport of #8969

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the 3.17.4 milestone Nov 18, 2025
…ent.

- Change variable names for more readable ones.
- Related to PRs #8706 and #8925.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
… user proxy.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
…keychain key name.

Signed-off-by: Camila Ayres <hello@camilasan.com>
… the keychain keys.

- Modernize function AbstractCredentials::keychainkey.
- Add string to save current or legacy application name.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
…on steps.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
…ame.

Remove emit signal call: it would trigger the call for saveAccountHelper() which in turn would call
persist() again.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the backport/8969/stable-3.17 branch from 5fe4f83 to 5de160b Compare November 18, 2025 14:46
@camilasan camilasan marked this pull request as ready for review November 18, 2025 14:46
@camilasan camilasan requested a review from i2h3 as a code owner November 18, 2025 14:46
@mgallien mgallien enabled auto-merge November 18, 2025 14:47
…us version of the client.

Enabled/disable the checkbox when changing the server notifications setting.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Only valid for Windows.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the backport/8969/stable-3.17 branch from 5de160b to 2b7692f Compare November 18, 2025 14:49
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9101.zip

Digest: sha256:5870945b27c336f1630ff442c81f4b8f0dd6f3433986d2efe0c1cf5201323812

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 1ff2ddf into stable-3.17 Nov 18, 2025
16 checks passed
@mgallien mgallien deleted the backport/8969/stable-3.17 branch November 18, 2025 15:11
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.3% Coverage on New Code (required ≥ 80%)
48 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants