Skip to content

[stable-4.0] fix(migration): set all settings and keychain keys from the previous version of the client. #9100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgallien merged 15 commits into from
Nov 18, 2025
Merged

[stable-4.0] fix(migration): set all settings and keychain keys from the previous version of the client. #9100

mgallien merged 15 commits into from
Nov 18, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Nov 18, 2025

Backport of PR #8969

@backportbot backportbot bot requested a review from mgallien November 18, 2025 14:03
@backportbot backportbot bot requested a review from nilsding as a code owner November 18, 2025 14:03
@backportbot backportbot bot requested a review from nilsding November 18, 2025 14:03
@backportbot backportbot bot added this to the 4.0.2 milestone Nov 18, 2025
@camilasan @backportbot
fix(migration): set all settings from the previous version of the cli…
44e24e6 
…ent.

- Change variable names for more readable ones.
- Related to PRs #8706 and #8925.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
fix(migration): check for legacy app name group for updater setting.
f17be94 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
fix(migration): migrate proxy global setting to user when there is no…
c020075 
… user proxy.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
feat(migration): add helper functions to handle migration/upgrade.
00b2584 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
fix(credentials): check for certificate existence before setting the …
b012c00 
…keychain key name.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
feat(credentials): use the app name or the unbranded name to retrieve…
93a316a 
… the keychain keys.

- Modernize function AbstractCredentials::keychainkey.
- Add string to save current or legacy application name.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
fix(test): update function fetchFromKeychain signature.
61d7e12 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
refactor(configfile): use migration helper functions to track migrati…
4298898 
…on steps.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
fix(credentials): add Q_UNUSED.
13ba13f 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
feat(migration): track migration phases with an enum.
758764b 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
style(account): modernize account functions.
2e218b8 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
fix(credentials): when legacy creds are found, save it with new app n…
80a3496 
…ame.

Remove emit signal call: it would trigger the call for saveAccountHelper() which in turn would call
persist() again.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
fix(migration): set use new big folders correctly.
4502cd8 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
fix(migration): make sure the checkbox are consistent with the previo…
b140e42 
…us version of the client.

Enabled/disable the checkbox when changing the server notifications setting.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
refactor(credentials): use member function to change keychain key name.
c1b23bd 
Only valid for Windows.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-9100.zip

Digest: sha256:d370ddc474dd5fca3866782ce7c1f9fedd944375d9c2bab9ff6efc8530b3aa5b

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 18, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
18.0% Coverage on New Code (required ≥ 80%)
48 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 8c40e79 into stable-4.0 Nov 18, 2025
19 of 21 checks passed
@mgallien mgallien deleted the backport/8969/stable-4.0 branch November 18, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Assignees

@camilasan camilasan

Labels

3. to review

Projects

None yet

Milestone

4.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@mgallien @camilasan