Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.14] Make shares distinguishable if there are sharees with the same display name #7364

Merged
merged 7 commits into from
Oct 18, 2024
Merged

[stable-3.14] Make shares distinguishable if there are sharees with the same display name #7364

merged 7 commits into from
Oct 18, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 18, 2024

Backport of PR #7339

@claucambra @backportbot
Add ability to make share sharee displayname more verbose
194222a 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Check for and store indices of shares with duplicate display names
1169c0b 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Display more verbose share display names for shares that have sharees…
6d88f04 
… with identical display names

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Make sure to update display of all duplicate display name shares
c42617c 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Clean up check for equality between sharee display names
cc4e259 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Store duplicate indices as key-value pair with value storing bucket o…
10ff7dd 
…f all duplicates

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Ensure on removal of share that display string is updated for last (n…
d07cb2c 
…ow non-)duplicate share

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@backportbot backportbot bot added feature: 👥 sharing Sharing dialog and functionalities. 3. to review labels Oct 18, 2024
@backportbot backportbot bot added this to the 3.14.2 milestone Oct 18, 2024
@mgallien mgallien merged commit 6add67b into stable-3.14 Oct 18, 2024
9 of 14 checks passed
@mgallien mgallien deleted the backport/7339/stable-3.14 branch October 18, 2024 09:09
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7364-d07cb2c69f902cea48ef7b40a6b31deb750b69c9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

Assignees

@claucambra claucambra

Labels
3. to review feature: 👥 sharing Sharing dialog and functionalities.
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.
3 participants
@nextcloud-desktop-bot @mgallien @claucambra