Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] Bugfix/remove read only folders in read only folders #7021

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 22, 2024

Backport of PR #7020

@backportbot backportbot bot requested a review from mgallien August 22, 2024 12:55
@backportbot backportbot bot added this to the 3.13.3 milestone Aug 22, 2024
sometime we need to create a folder on server because some local files
or folders modifications would be lost without that

in that case instead of locally deleting teh folder, we create it back
on server

when doing that, it is important to check the remote permissions such
that we do not try to create a folder in a read-only folder on server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
let unexpected new folders in read-only folders be read-write

would be done for folders that are inside a read-only folder and cannot
be uploaded because the parent folder is realy read-only

most probably those folders should never have been there

in case they would be read-only, users cannot delete them, in such
situation, letting them be read-write again should really help

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7021-589ad42314b22aaac1f4b421acf0e552660ebb94-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Aug 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
43.8% Coverage on New Code (required ≥ 80%)
9 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 3aee7c4 into stable-3.13 Aug 23, 2024
10 of 13 checks passed
@mgallien mgallien deleted the backport/7020/stable-3.13 branch August 23, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants