Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permanent freeze upon opening macOS VFS settings #6892

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Fix permanent freeze upon opening macOS VFS settings #6892

merged 3 commits into from
Jul 9, 2024

Conversation

claucambra
Copy link
Collaborator

Don't wait forever for the file provider extension to reply to the client's request, time out after 3 seconds

@claucambra
Fix _Generic C11 extension compile warning under clang
aa0ecd5 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Do not wait forever to get fast enumeration state from file provider …
1f243c3 
…extension service

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add check to detect if we timed out wait for file provider extension …
953b103 
…service response on fast enumeration state

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra self-assigned this Jul 9, 2024
@marcotrevisan
Copy link

A workaround was to quit the client as a first step, reopen it and then it would not freeze opening the settings.
Will the timeout introduced make it possible to avoid the workaround and simply retry?

@claucambra
Copy link
Collaborator Author

A workaround was to quit the client as a first step, reopen it and then it would not freeze opening the settings. Will the timeout introduced make it possible to avoid the workaround and simply retry?

This PR will make the client stop awaiting a response from the file provider module after 3 seconds, letting the settings window open as usual (just with a potentially inaccurate fast enumeration state reported in the settings window)

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6892-953b1035320c94de60c23a52b61f6d9c8599fe54-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@claucambra
Copy link
Collaborator Author

/backport to stable-3.13

@claucambra claucambra merged commit ba155be into master Jul 9, 2024
11 of 14 checks passed
@claucambra claucambra deleted the bugfix/avoid-freeze-vfs-settings branch July 9, 2024 10:09
@backportbot backportbot bot mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@claucambra claucambra

Labels
feature: 💽 virtual filesystem os: 🍎 macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @marcotrevisan @nextcloud-desktop-bot @camilasan