Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Edit" with "Open in browser" #6779

Merged

Conversation

Jerome-Herbinet
Copy link
Member

Fixes: #5460

Reviewers' test is needed.

@Jerome-Herbinet Jerome-Herbinet added 2. to review enhancement enhancement of a already implemented feature/code labels May 24, 2024
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-replace-edit-with-open-in-browser branch from c2d8b79 to ccfd3a3 Compare May 27, 2024 07:45
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@mgallien mgallien force-pushed the Jerome-Herbinet-replace-edit-with-open-in-browser branch from ccfd3a3 to dd1f32d Compare June 3, 2024 06:55
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6779-dd1f32df65c73bf76665e3acb43863bb59f0dee5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@claucambra claucambra merged commit e1b96c2 into master Jun 3, 2024
12 of 14 checks passed
@claucambra claucambra deleted the Jerome-Herbinet-replace-edit-with-open-in-browser branch June 3, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. to review enhancement enhancement of a already implemented feature/code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 different wordings "Edit" and "Open in browser" for one same action (it seems weird and apparently useless)
4 participants