Display a message to upgrade client if minimumSupportedDesktopVersion is thrown - #6405
Conversation
nimishavijay
left a comment
nimishavijay
left a comment
There was a problem hiding this comment.
Nice! Definitely such a big improvement! Only a minor change in the wording:
Unable to connect to Nextcloud.
This version of the client is unsupported. Upgrade to version 3.0.0 or later
not blocking, but if possible we should link to the latest version or instructions on how to update, but that can be a follow-up :)
claucambra
left a comment
claucambra
left a comment
There was a problem hiding this comment.
Code-wise looks good :)
this text change will go in the server side PR: nextcloud/server#43281 |
|
@camilasan it is unclear for me if you are waiting for more feedback or if we can merge this ? |
e8e7375 to
92335db
Compare
92335db to
8567acd
Compare
Signed-off-by: Camila Ayres <hello@camilasan.com>
…ingBody. - Add const auto. - Remove extra error message information to make it more user friendly. Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
8567acd to
d6df907
Compare
|
|
AppImage file: nextcloud-PR-6405-d6df90796197f1203cf8586966a671d5bd97b4c6-x86_64.AppImage |
|
/backport to stable-3.12 |
|
The backport to # Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12
# Create the new backport branch
git checkout -b backport/6405/stable-3.12
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 211233dd f197ce07 17ffc06d d6df9079
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6405/stable-3.12Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable-3.12 |
|
The backport to # Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12
# Create the new backport branch
git checkout -b backport/6405/stable-3.12
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 211233dd f197ce07 17ffc06d d6df9079
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6405/stable-3.12Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
5 participants
minimumSupportedDesktopVersionis thrown #6273to do:
Before:
After:
Systray message