Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show failure popul for VFS when hydration finished with code 200 or 204. #6160

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Do not show failure popul for VFS when hydration finished with code 200 or 204. #6160

merged 1 commit into from
Oct 24, 2023

Conversation

allexzander
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Merging #6160 (f149e61) into master (bc91eac) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head f149e61 differs from pull request most recent head 5f9e04d. Consider uploading reports for the commit 5f9e04d to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6160   +/-   ##
=======================================
  Coverage   60.54%   60.55%           
=======================================
  Files         145      145           
  Lines       18833    18837    +4     
=======================================
+ Hits        11403    11407    +4     
  Misses       7430     7430
Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 54.54% <100.00%> (+0.88%) ⬆️

@allexzander
Do not show failure popul for VFS when hydration finished with code 2…
5f9e04d 
…00 or 204.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/vfs-error-dialog-on-uknown-error branch from f149e61 to 5f9e04d Compare October 24, 2023 11:00
@allexzander allexzander merged commit 511af3a into master Oct 24, 2023
8 of 10 checks passed
@allexzander allexzander deleted the bugfix/vfs-error-dialog-on-uknown-error branch October 24, 2023 11:00
@allexzander
Copy link
Contributor Author

/backport to stable-3.10

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 24, 2023
Merged
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6160-5f9e04dad38f73baf402e0ea4871f50c34a0819c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@allexzander @nextcloud-desktop-bot @claucambra @mgallien