Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Chunk v2 upload headers #6084

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix Chunk v2 upload headers #6084

merged 1 commit into from
Sep 22, 2023

Conversation

claucambra
Copy link
Collaborator

Fixes #6079

@claucambra
Fix Chunk v2 upload headers
a045dd7 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Copy link
Collaborator Author

/backport to stable-3.10

@claucambra claucambra mentioned this pull request Sep 22, 2023
Closed
8 tasks
@claucambra claucambra self-assigned this Sep 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #6084 (a045dd7) into master (4660c6e) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6084   +/-   ##
=======================================
  Coverage   60.33%   60.33%           
=======================================
  Files         145      145           
  Lines       18793    18793           
=======================================
  Hits        11338    11338           
  Misses       7455     7455
Files Changed Coverage Δ
src/libsync/propagateuploadng.cpp 84.72% <100.00%> (ø)

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6084-a045dd71ae6fceca19a7647d47c8a17be8f77a63-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 2660b04 into master Sep 22, 2023
13 checks passed
@claucambra claucambra deleted the bugfix/chunkv2-destination-header branch September 22, 2023 12:08
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 22, 2023
Merged
@wmeneses
Copy link

wmeneses commented Oct 5, 2023

Hi, how can I test this image, I have more than 300 clients with problems to synchronize and I had to go back to version 3.9.4, what alternatives do I have to solve this bug? thank you very much.

@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.11.0
5 participants
@claucambra @nextcloud-desktop-bot @wmeneses @allexzander @mgallien