Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.10] Bugfix/remove dead oauth code #6075

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

claucambra
Copy link
Collaborator

No description provided.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6075-498316c2af4b04b99f0eb386979f346c623520af-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #6075 (498316c) into stable-3.10 (d299e57) will decrease coverage by 0.10%.
Report is 8 commits behind head on stable-3.10.
The diff coverage is 27.27%.

Additional details and impacted files
@@               Coverage Diff               @@
##           stable-3.10    #6075      +/-   ##
===============================================
- Coverage        60.42%   60.33%   -0.10%     
===============================================
  Files              145      145              
  Lines            18868    18793      -75     
===============================================
- Hits             11401    11338      -63     
+ Misses            7467     7455      -12     
Files Changed Coverage Δ
src/libsync/creds/httpcredentials.h 25.00% <ø> (+5.00%) ⬆️
src/libsync/networkjobs.cpp 54.63% <0.00%> (-4.67%) ⬇️
src/libsync/networkjobs.h 4.16% <ø> (-8.34%) ⬇️
src/libsync/propagatedownload.cpp 66.85% <ø> (ø)
src/libsync/theme.cpp 19.35% <ø> (-0.35%) ⬇️
src/libsync/theme.h 60.00% <ø> (ø)
src/libsync/creds/httpcredentials.cpp 20.14% <42.85%> (+2.89%) ⬆️

... and 4 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@claucambra claucambra merged commit 61cba1e into stable-3.10 Sep 19, 2023
10 of 12 checks passed
@claucambra claucambra deleted the bugfix/remove-dead-uauth-code-3.10 branch September 19, 2023 09:09
@mgallien mgallien added this to the 3.10.2 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants