Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with the new libcloudproviders integration #6031

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

tintou
Copy link
Contributor

@tintou tintou commented Sep 6, 2023

Since libcloudproviders 0.3.3 it is possible to specify the interface name directly in the .desktop file, and thus allowing it to be integrated when using a containerized client.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #6031 (7d74fd2) into master (4c69cbf) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6031      +/-   ##
==========================================
- Coverage   60.14%   60.14%   -0.01%     
==========================================
  Files         145      145              
  Lines       18868    18868              
==========================================
- Hits        11349    11348       -1     
- Misses       7519     7520       +1     

see 1 file with indirect coverage changes

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Since libcloudproviders 0.3.3 it is possible to specify the interface name directly
in the .desktop file, and thus allowing it to be integrated when using a containerized
client.

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
@claucambra
Copy link
Collaborator

/backport to stable-3.10

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6031-7d74fd2c039a6c9b2879a281e670482d333b8f6b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 298e069 into nextcloud:master Sep 7, 2023
9 of 10 checks passed
@mgallien mgallien added this to the 3.11.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants