Skip to content

Display file tags in File Details #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
claucambra merged 31 commits into from
May 16, 2023
Merged

Display file tags in File Details #5596

claucambra merged 31 commits into from
May 16, 2023

Conversation

@claucambra
Copy link
Contributor

@claucambra claucambra commented Apr 12, 2023 •
edited
Loading

As discussed

  • if more than 2 tags, please provide rest of tags in overflow menu

Screenshot 2023-04-12 at 01 34 30

@claucambra claucambra self-assigned this Apr 12, 2023
github-actions[bot]
github-actions bot previously requested changes Apr 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Merging #5596 (b440e30) into master (2d27e4a) will increase coverage by 0.11%.
The diff coverage is 93.67%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5596      +/-   ##
==========================================
+ Coverage   59.28%   59.39%   +0.11%     
==========================================
  Files         143      143              
  Lines       18463    18520      +57     
==========================================
+ Hits        10945    11000      +55     
- Misses       7518     7520       +2
Impacted Files Coverage Δ
src/libsync/networkjobs.h 4.34% <ø> (ø)
src/libsync/networkjobs.cpp 54.65% <93.67%> (+3.14%) ⬆️

... and 2 files with indirect coverage changes

@claucambra claucambra force-pushed the feature/file-detail-tags branch from 8627a41 to ef00ed8 Compare April 12, 2023 05:08
@github-actions github-actions bot dismissed their stale review April 12, 2023 05:23

No clang-tidy warnings found so I assume my comments were addressed

@claucambra claucambra mentioned this pull request Apr 12, 2023
Closed
7 tasks
@claucambra claucambra force-pushed the feature/file-detail-tags branch 9 times, most recently from 8705f42 to 0fcf2aa Compare April 24, 2023 11:20
allexzander
allexzander approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra Approved, but I could not test it locally as I am not able to add tags on any server

claucambra added 11 commits May 16, 2023 18:23
@claucambra
Add FileTag QML component
0bdab1e 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add a FileTagModel
f763bd0 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Get account and relativeserverpath in constructor for FileTagModel
84c8392 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add capability for FileTagModel to fetch tags
9cc241b 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Implement FileTagModel QAbstractListModel methods
49b5fb3 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Expose account and serverRelativePath of FileTagModel as QPROPERTYs
213e374 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add ability to limit maximum amount of tags displayed
c6d29e7 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Instantiate FileTagModel in FileDetails
791eb87 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Simplify FileTag component
a3fc467 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Display filetags in file details window
cb8cab6 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Simplify file tag model updating in filedetails, only require folder …
65e7f6d 
…pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra added 20 commits May 16, 2023 18:23
@claucambra
Fix layout of tags with differing sizes and oversized tags
e2bd9e6 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Modernise PropfindJob with new for and const auto
06b3dc9 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Simplify Propfind XML parsing using QDomDocument instead of complex Q…
43bcecd 
…XmlStreamReader-based parsing

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Use constexpr in networkjobs notModifiedStatusCode
9324fe0 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Do not use magic string for propfind prop element tag name
a386d8f 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Clean up includes in networkjobs
6e9fed0 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix for header fix
@claucambra
Extract propfind result data processing into separate method
b5cc4b4 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Properly parse tags in propfind request
29c1713 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Extract propfind tag xml node processing into separate method
bfb720f 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Implement support for system tags in propfindjob
045541d 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix
@claucambra
Add support for system tags in filetagmodel
b79a038 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add initial testing setup for file tag model
955f4de 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add FakePropfindReply that accepts raw QByteArray as payload
89d7e17 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Provide different propfind replies depending on request props in test…
ccb07af 
…filetagmode

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add test for tags in filetagmodel
6c68341 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Notify change in tags when maxTags set in filetagmodel
1bab57b 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add test for maxTags in FileTagModel
73b94bc 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Test important properties in testfiletagmodel
ce22c40 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add overflow tag string property to filetagmodel which stringifies om…
30830b4 
…itted tags

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Display tooltip showing names of overflowing tags in FileDetailsPage'…
b440e30 
…s overflow tag

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the feature/file-detail-tags branch from d77f6da to b440e30 Compare May 16, 2023 10:23
@claucambra claucambra merged commit 90c34e9 into master May 16, 2023
@claucambra claucambra deleted the feature/file-detail-tags branch May 16, 2023 11:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

nextcloud-desktop-bot commented May 16, 2023

AppImage file: nextcloud-PR-5596-b440e3011d0e96240f99b27e0c7a53f2ac524f21-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.9.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

+1 more reviewer

@allexzander allexzander allexzander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@claucambra claucambra

Labels

None yet

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@claucambra @nextcloud-desktop-bot @allexzander @mgallien