Migrate old configs #5362
Merged
Migrate old configs #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilasan
requested review from
mgallien,
tobiasKaminsky,
allexzander and
claucambra
allexzander
reviewed
Jan 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5362 +/- ##
==========================================
- Coverage 58.24% 57.99% -0.25%
==========================================
Files 141 139 -2
Lines 18008 17728 -280
==========================================
- Hits 10488 10282 -206
+ Misses 7520 7446 -74
|
camilasan
force-pushed
the
bugfix/migrate
branch
from
c6b437a
to
9e28d16
Compare
allexzander
approved these changes
Jan 24, 2023
claucambra
requested changes
Jan 24, 2023
camilasan
force-pushed
the
bugfix/migrate
branch
from
9e28d16
to
aa3ce7a
Compare
claucambra
approved these changes
Jan 25, 2023
added 7 commits
January 30, 2023 09:44
Use QStandardPaths::writableLocation instead. Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
…hange of the client. Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
mgallien
force-pushed
the
bugfix/migrate
branch
from
aa3ce7a
to
a3e08aa
Compare
|
SonarCloud Quality Gate failed. |
|
AppImage file: nextcloud-PR-5362-a3e08aae3b6b9ac0e198ce8523f113c0a4959219-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in the config file name, there has been issues when the desktop client.
We already had code that did migrate configs from different folders, now this change would check for previous config files independent of the name. It will back up the previous config and rename the file to the new application name when there is an update of the client version.
I am sure there might be drawbacks to this. wdyt?
There is already a notification in place to tell the user there is a previous config.
Previous config:
Notification:
New config:
After another upgrade, it should proceed to doing backups:
