Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/move shellextensions to root installdir #5295

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Feature/move shellextensions to root installdir #5295

merged 1 commit into from
Dec 29, 2022

Conversation

allexzander
Copy link
Contributor

This is the first part of fix for #4848
The second part is in another repo.

@allexzander allexzander force-pushed the feature/move-shellextensions-to-root-installdir branch from cc725f5 to 99d6f92 Compare December 22, 2022 17:53
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #5295 (cc725f5) into master (77bb54c) will not change coverage.
The diff coverage is n/a.

❗ Current head cc725f5 differs from pull request most recent head 99d6f92. Consider uploading reports for the commit 99d6f92 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5295   +/-   ##
=======================================
  Coverage   57.49%   57.49%           
=======================================
  Files         139      139           
  Lines       17595    17595           
=======================================
  Hits        10117    10117           
  Misses       7478     7478

@allexzander
Move Windows shell extension DLLs to a root installation directory.
7f6c2f9 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/move-shellextensions-to-root-installdir branch from 99d6f92 to 7f6c2f9 Compare December 29, 2022 16:59
@allexzander allexzander merged commit 399142f into master Dec 29, 2022
@allexzander allexzander deleted the feature/move-shellextensions-to-root-installdir branch December 29, 2022 16:59
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5295-7f6c2f946bc4103739067deee693be264796be24-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@allexzander @nextcloud-desktop-bot @claucambra @mgallien