Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence sync termination errors when running EditLocallyJob. #5261

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Silence sync termination errors when running EditLocallyJob. #5261

merged 1 commit into from
Dec 12, 2022

Conversation

allexzander
Copy link
Contributor

Signed-off-by: alex-z blackslayer4@gmail.com

Will fix #5205

claucambra
claucambra reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise it looks fine, but the idea of having a toggle for silencing logging of errors makes me fear for what might happen if it is not correctly turned on again

Would it be sensible to have a timer to re-enable logging of errors after a specified amount of time (long after the need for them to be silenced can be over)?

@allexzander
Copy link
Contributor Author

Code-wise it looks fine, but the idea of having a toggle for silencing logging of errors makes me fear for what might happen if it is not correctly turned on again

Would it be sensible to have a timer to re-enable logging of errors after a specified amount of time (long after the need for them to be silenced can be over)?

I don't sync the timer is going to be reliable. But, I have an idea of how to improve the toggle unsetting logic.

@allexzander allexzander force-pushed the feature/do-not-show-error-status-on-editlocally-abort branch 2 times, most recently from 6c5e2f4 to fd896e2 Compare December 12, 2022 16:35
@allexzander
Silence sync termination errors when running EditLocallyJob.
f7ef2e5 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/do-not-show-error-status-on-editlocally-abort branch from fd896e2 to f7ef2e5 Compare December 12, 2022 16:40
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5261-f7ef2e5f44d1722cff43fadc437e570a9894a921-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@allexzander allexzander merged commit 73307a1 into master Dec 12, 2022
@allexzander allexzander deleted the feature/do-not-show-error-status-on-editlocally-abort branch December 12, 2022 17:42
@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

[Follow up] Do not show postponed sync as "cancelled"
4 participants
@allexzander @nextcloud-desktop-bot @claucambra @mgallien