Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure more QML text components are rendering things as plain text #5231

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

claucambra
Copy link
Collaborator

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine but some e2e tests failed
can you check ?

@claucambra
Copy link
Collaborator Author

seems fine but some e2e tests failed
can you check ?

TestChunkingNG failed and this is not touched by this PR

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5231-00fcb6e01d1ea896bb491f8162456e160c3dd45b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit d2d7b45 into master Dec 1, 2022
@mgallien mgallien deleted the bugfix/more-plain-text branch December 1, 2022 14:22
@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants