Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync progress bar colours in dark mode #4986

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

claucambra
Copy link
Collaborator

Dark Light
With fix Screenshot 2022-09-29 at 19 18 53 Screenshot 2022-09-29 at 19 18 46
Before fix Screenshot 2022-09-29 at 19 20 48 Screenshot 2022-09-29 at 19 20 54

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #4986 (6137fe2) into master (1ccc170) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4986      +/-   ##
==========================================
+ Coverage   57.13%   57.16%   +0.02%     
==========================================
  Files         138      138              
  Lines       17221    17221              
==========================================
+ Hits         9839     9844       +5     
+ Misses       7382     7377       -5     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 64.75% <0.00%> (+0.14%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.65% <0.00%> (+0.22%) ⬆️
src/libsync/discovery.cpp 84.24% <0.00%> (+0.29%) ⬆️

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4986-6137fe246e7c8964343886b08a583b8d74159db5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 9078cca into master Sep 29, 2022
@claucambra claucambra deleted the bugfix/sync-progress-bar-dark branch September 29, 2022 20:37
@mgallien mgallien added this to the 3.7.0 milestone Oct 3, 2022
@claucambra
Copy link
Collaborator Author

/backport to stable-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants