Clean up QML type and singleton registration #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
Codecov Report
@@ Coverage Diff @@
## master #4817 +/- ##
==========================================
+ Coverage 57.15% 57.16% +0.01%
==========================================
Files 138 138
Lines 17135 17135
==========================================
+ Hits 9794 9796 +2
+ Misses 7341 7339 -2
|
mgallien
force-pushed
the
bugfix/cleanup-qml-registration
branch
from
bd22ed9
to
7fe53a2
Compare
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/cleanup-qml-registration
branch
from
7fe53a2
to
e79ced2
Compare
|
AppImage file: nextcloud-PR-4817-e79ced22aebd1c9d5455fd9b5371ca122779d9ba-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we register QML types and singletons in two separate places,
main.cppandsystray.cpp. I suppose this was done to prevent errors initialising things where they shouldn't be; unfortunately the result is that nothing is initialised in the code near to where the QML engine is actually started, and it is of course separated.This PR declares all the QML types to register in
owncloudgui.cpp, where the QML engine is started, and cleans up the registration of types and especially singletons.Signed-off-by: Claudio Cambra claudio.cambra@gmail.com