Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate padding around the menu separator in the account menu #4802

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

claucambra
Copy link
Collaborator

A small PR for the visual adjustment of a separator

After changes:

Screenshot 2022-08-02 at 12 53 41

Before changes:

Screenshot 2022-08-02 at 12 56 41

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #4802 (81bb290) into master (dab1a19) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4802      +/-   ##
==========================================
- Coverage   57.23%   57.22%   -0.02%     
==========================================
  Files         138      138              
  Lines       17144    17144              
==========================================
- Hits         9813     9811       -2     
- Misses       7331     7333       +2     
Impacted Files Coverage Δ
src/libsync/discovery.cpp 84.56% <0.00%> (-0.30%) ⬇️
src/libsync/propagatedownload.cpp 65.18% <0.00%> (-0.15%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.71% <0.00%> (+0.45%) ⬆️

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better! :)

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4802-81bb290e4c4ad84e3f2da8153e303206ce81679e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit ec2bba7 into master Aug 8, 2022
@claucambra claucambra deleted the work/account-menu-separator branch August 8, 2022 14:50
@mgallien mgallien added this to the 3.6.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants