Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fractional scaling (#4776) #4779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

usatiuk
Copy link

@usatiuk usatiuk commented Jul 26, 2022

Fixes #4776

Not sure if I put this line 100% in the right place, but it seems to work.

src/gui/main.cpp Outdated Show resolved Hide resolved
@usatiuk usatiuk force-pushed the enable-fractional-scaling branch 3 times, most recently from d714d87 to e3377cd Compare July 28, 2022 10:25
Signed-off-by: Stepan Usatiuk <stepan@usatiuk.com>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4779-770ad08bfd63a96c6ab4f6289eaffd1bfe586a10-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@Hardexit
Copy link

I would also be very interested in the solution of the problem, on the dell notebooks you can not use nextcloud.

@usatiuk
Copy link
Author

usatiuk commented Nov 7, 2022

Just as a bump, this will also fix these issues: #4040 #3561 (I think)

@alphasixtyfive
Copy link

Let's have it merged please, it is impossible to use with 4K monitors.

@badshah400
Copy link

Thanks for the fix. This fixes it for me.

I suppose this is also needed for the crashreporter window separately:

Index: desktop-3.9.0/src/crashreporter/main.cpp
===================================================================
--- desktop-3.9.0.orig/src/crashreporter/main.cpp
+++ desktop-3.9.0/src/crashreporter/main.cpp
@@ -25,6 +25,8 @@
 int main(int argc, char *argv[])
 {
     QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps, true);
+    QApplication::setHighDpiScaleFactorRoundingPolicy(
+            Qt::HighDpiScaleFactorRoundingPolicy::PassThrough);
 #ifdef Q_OS_WIN
     QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling, true);
 #endif // !Q_OS_WIN

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems mostly fine when running on top of wayland using Qt 5.15
except some icons are blurry and would need a fix before we can enable fractional scaling
image

@badshah400
Copy link

seems mostly fine when running on top of wayland using Qt 5.15 except some icons are blurry and would need a fix before we can enable fractional scaling

Hi, do you see blurred icons only on the "main window" or everywhere (e.g. settings window)?

@mgallien
Copy link
Collaborator

@badshah400 I tested the main dialog and saw one issue there
this most probably should be fixed before that can be tested more thoroughly

@joshtrichards joshtrichards added the hotspot: visual Window positioning, font sizing, etc. label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. to review hotspot: visual Window positioning, font sizing, etc.
Projects
None yet
9 participants