Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the share dialog resizeable #4663

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jun 22, 2022

Screen.Recording.2022-06-22.at.15.00.42.mov

The default size of the dialog is now larger as well.

Closes #4134 and closes #4533

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #4663 (2fe6e07) into master (5337d4b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4663   +/-   ##
=======================================
  Coverage   56.42%   56.42%           
=======================================
  Files         138      138           
  Lines       17071    17071           
=======================================
+ Hits         9632     9633    +1     
+ Misses       7439     7438    -1     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.33% <0.00%> (+0.14%) ⬆️

@claucambra claucambra force-pushed the feature/resizeable-share-dialog branch 3 times, most recently from f9325d2 to 4800930 Compare June 22, 2022 13:01
src/gui/sharedialog.cpp Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the feature/resizeable-share-dialog branch 2 times, most recently from 9eecef9 to aec9bf4 Compare June 24, 2022 09:51
@mgallien mgallien force-pushed the feature/resizeable-share-dialog branch from aec9bf4 to faf789f Compare June 24, 2022 10:19
@claucambra claucambra force-pushed the feature/resizeable-share-dialog branch 2 times, most recently from b3d20da to a659fa4 Compare June 24, 2022 10:44
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the feature/resizeable-share-dialog branch from a659fa4 to 2fe6e07 Compare June 24, 2022 11:45
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4663-2fe6e075b6dd9cdd4d418ea50ef7cde20813ecc7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit f27aa4f into master Jun 24, 2022
@claucambra claucambra deleted the feature/resizeable-share-dialog branch June 24, 2022 12:35
@mgallien mgallien added this to the 3.6.0 milestone Jun 24, 2022
@claucambra
Copy link
Collaborator Author

/backport to stable-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants