Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault when _transferDataSocket is nullptr. #4656

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

camilasan
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #4656 (a97c07f) into master (19bb164) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4656      +/-   ##
==========================================
- Coverage   56.43%   56.42%   -0.02%     
==========================================
  Files         138      138              
  Lines       17070    17071       +1     
==========================================
- Hits         9634     9632       -2     
- Misses       7436     7439       +3     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 52.68% <100.00%> (+0.25%) ⬆️
src/libsync/propagateupload.cpp 76.41% <0.00%> (-0.66%) ⬇️

@camilasan
Copy link
Member Author

/rebase

Signed-off-by: Camila <hello@camila.codes>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4656-a97c07f1487a6a86cdcf01180599b77595431257-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@camilasan camilasan merged commit db1454b into master Jun 21, 2022
@camilasan camilasan deleted the bugfix/cfapi-test branch June 21, 2022 09:48
@mgallien mgallien added this to the 3.6.0 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants