Remove assert, it is no longer useful. #4645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
approved these changes
Jun 15, 2022
claucambra
approved these changes
Jun 15, 2022
mgallien
force-pushed
the
bugfix/windows-tests
branch
from
43c2063
to
042b61b
Compare
Signed-off-by: Camila <hello@camila.codes>
mgallien
force-pushed
the
bugfix/windows-tests
branch
from
042b61b
to
65d012a
Compare
|
AppImage file: Nextcloud-PR-4645-65d012afea635b960af3c3a7b1bdeaa50ca9523c-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #4645 +/- ##
==========================================
+ Coverage 56.42% 56.43% +0.01%
==========================================
Files 138 138
Lines 17070 17070
==========================================
+ Hits 9631 9633 +2
+ Misses 7439 7437 -2
|
|
/backport to stable-3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should fix the failing test in #4640.