Strongly agree that this is something we should so.

To explain: QtQuick Controls components have default styling that, while functional, is completely discordant with the UI design we are going for in the desktop client. A great example of this is #4624 where the difference is very clear.

Our solution thus far has been to add custom styling elements to each QML component we use in the client. Unfortunately that means styling every single element we use in the client that is written in QML. This creates a significant amount of duplicated code and duplicated work which needs to be repeated every time a new component is written in QML, especially when we are talking about additional views, pages or windows. This is also error-prone, as for instance, we need to ensure that system-level theme switching is correctly handled by all of these components. We also need to ensure that everything remains readable across system themes.

Fortunately, QtQuick supports custom styles which completely eliminates the need for doing this by hand. Custom styles apply the type of customisation we want in the desktop client to all the components in the custom style. Using a custom style will significantly reduce our code footprint, make it much easier to create new QML components in the future, guarantee client-wide dark mode compatibility in QML components, allow us to much more easily change our design in the future, and so on.

@tobiasKaminsky @mgallien thoughts on putting this on the board? :)

Use a QQC2 theme to implement custom styling in tray window #3973

Description

CarlSchwanopenedon Nov 12, 2021

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

CarlSchwan
openedon Nov 12, 2021