Skip to content

Get rid of VERSION.cmake and NextcloudCPack.cmake #1613

Open

Description

Expected behaviour

Versions should be handled in CMakeLists.txt, VERSION.cmake adds an extra layer of complexity.
This is also true for NextcloudCPack.cmake

Actual behaviour

There is this extra layer ...

Steps to reproduce

  1. try to override the "suffix" part which adds an 'git' to the version in CMakeLists.txt
  2. have a look at the generated version.h
  3. be surprised

Operating system: debian sid, rest doesn't matter

This is the first PR of a two parted set of Bugs and PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    2. to reviewbuildingIssues related to building the clientenhancementenhancement of a already implemented feature/code

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions