card title: prevent space and no text #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jakobroehrl
force-pushed
the
fix/emptyCardTitle
branch
from
7c55d05 to
8ff1b84
Compare
juliusknorr
reviewed
Sep 22, 2020
juliusknorr
reviewed
Sep 22, 2020
|
So you are only limiting it in the UI - please keep in mind that performing this validation at the backend, it will be a breaking change :) |
jakobroehrl
force-pushed
the
fix/emptyCardTitle
branch
from
8ff1b84 to
233ef93
Compare
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
juliusknorr
force-pushed
the
fix/emptyCardTitle
branch
from
233ef93 to
7bddcb8
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
approved these changes
Sep 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jakob Röhrl jakob.roehrl@web.de