chore(deps): upgrade to vue 3 and vite #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyteinsky
reviewed
Jul 2, 2025
Contributor
kyteinsky
left a comment
kyteinsky
left a comment
There was a problem hiding this comment.
sweet, thanks!
The text seems off here. Would you mind fixing it here and reporting it upstream in the vue library if not already reported (https://github.com/nextcloud-libraries/nextcloud-vue)?
Member
Author
Not sure how to fix it here, but I did add an issue upstream. |
Member
Author
|
A fix is being made in the library. When 9.0.0-rc4 is out we can merge this. |
Member
Author
|
@kyteinsky 9.0.0-rc4 for the nextcloud vue libraries came out yesterday. We can now merge this. https://github.com/nextcloud-libraries/nextcloud-vue/releases/tag/v9.0.0-rc.4 |
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the repo for something else and noticed there wouldn't be much work needed to update to vue 3 and vite