Skip to content

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented May 14, 2025

New task type+provider to search instead of asking a question.

For now it performs a classic query to the backend but only returns the sources.
This requires adjustments in the assistant's custom input and output forms:

@kyteinsky What do you think about only supporting "none" and "providers" for the scope type? I'm not sure it makes sense to search with context chat in a specific directory.

@julien-nc julien-nc requested a review from kyteinsky May 26, 2025 13:08
Copy link
Contributor

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is good otherwise 🚀

julien-nc added 6 commits May 27, 2025 16:46
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc requested a review from kyteinsky May 27, 2025 14:50
@julien-nc julien-nc marked this pull request as ready for review May 27, 2025 14:51
@julien-nc julien-nc requested a review from marcelklehr as a code owner May 27, 2025 14:51
Copy link
Contributor

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psalm might be a little unhappy but I definitely am, thanks, works great 💚

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc merged commit dd359b8 into main May 28, 2025
16 checks passed
@julien-nc julien-nc deleted the enh/noid/search branch May 28, 2025 13:17
kyteinsky added a commit to nextcloud/context_chat_backend that referenced this pull request Jun 2, 2025
related changes:
- nextcloud/context_chat#129
- nextcloud/assistant#241

---------

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
@kyteinsky kyteinsky mentioned this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants