Skip to content

Sharing design and cdav request#706

Merged
skjnldsv merged 1 commit intomasterfrom
sharing
Nov 12, 2018
Merged

Sharing design and cdav request#706
skjnldsv merged 1 commit intomasterfrom
sharing

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 10, 2018

Last big step towards the beta! 🎉

@skjnldsv skjnldsv added 3. to review Waiting for reviews high High priority labels Nov 10, 2018
@skjnldsv skjnldsv added this to the 3.0.0 milestone Nov 10, 2018
@skjnldsv skjnldsv self-assigned this Nov 10, 2018
@skjnldsv skjnldsv mentioned this pull request Nov 10, 2018
Closed
7 tasks
sleepypioneer
sleepypioneer approved these changes Nov 10, 2018
View reviewed changes
Copy link
Member

@sleepypioneer sleepypioneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great work! missing the project but still feeling swamped with new stuff/community work

@georgehrke
Copy link
Member

georgehrke commented Nov 10, 2018

Quickly skimming the code looks good, will check in depth and test tonight.

@skjnldsv skjnldsv requested a review from georgehrke November 10, 2018 11:35
georgehrke
georgehrke previously requested changes Nov 11, 2018
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the contacts app doesn't load for me :/

#content is just empty, no error during build-js-production, no error message in the console 😕

@skjnldsv skjnldsv requested a review from georgehrke November 11, 2018 17:41
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 11, 2018

@georgehrke Done :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 12, 2018

Somehow the contacts app doesn't load for me :/
#content is just empty, no error during build-js-production, no error message in the console confused

Strange, try just to do a make

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 12, 2018 •
edited by skjnldsv
Loading

Somehow the contacts app doesn't load for me :/

#content is just empty, no error during build-js-production, no error message in the console confused

Same here

bildschirmfoto von 2018-11-12 10-59-08

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 12, 2018

Fixed :)

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 12, 2018 •
edited by skjnldsv
Loading

  • Bug? Created some contacts to test the app

bildschirmfoto von 2018-11-12 12-18-49

  • Bug?

bildschirmfoto von 2018-11-12 12-18-07

What shall I actually test here? 🙈

@ChristophWurst ChristophWurst mentioned this pull request Nov 12, 2018
Closed
@skjnldsv skjnldsv force-pushed the sharing branch 3 times, most recently from 9a3f83d to e848568 Compare November 12, 2018 17:57
@skjnldsv
Sharing design and cdav request
a79a8d6 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit faf4e4a into master Nov 12, 2018
@skjnldsv skjnldsv deleted the sharing branch November 12, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sleepypioneer sleepypioneer sleepypioneer approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@suntala suntala Awaiting requested review from suntala

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews high High priority

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @georgehrke @ChristophWurst @sleepypioneer