fix(deps): Upgrade @nextcloud/vue to fix focus-trap compatibility #4920
Conversation
Upgrade @nextcloud/vue from ^8.27.0 to ^8.34.0 to resolve focus-trap library version mismatch with the guests app. The mismatch caused "_setPausedState is not a function" error when opening the guest invite dialog from the Teams member picker. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
requested review from
GVodyanov,
SebastianKrupinski and
hamza221
as code owners
nfebe
force-pushed
the
fix/focus-trap-version-mismatch
branch
from
31b818d to
ff6515c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Hi @nfebe This probably needs a transformation exclusion like in calendar. |
Yes, I made a fix but I will review the recently suggested workaround as well. Should be done today. |
1 similar comment
Yes, I made a fix but I will review the recently suggested workaround as well. Should be done today. |
The jsdom test environment does not provide structuredClone, which is used by @nextcloud/vue components. Signed-off-by: nfebe <fenn25.fn@gmail.com>
| if (typeof structuredClone === 'undefined') { | ||
| global.structuredClone = (val) => JSON.parse(JSON.stringify(val)) | ||
| } |
There was a problem hiding this comment.
Available since Node 17 so should not be needed?
There was a problem hiding this comment.
Tests fail without it for some reason
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah its JSDOM:
Upgrade @nextcloud/vue from ^8.27.0 to ^8.34.0 to resolve focus-trap library version mismatch with the guests app. The mismatch caused "_setPausedState is not a function" error when opening the guest invite dialog from the Teams member picker.
Without this the "Invite guest" modal does not work over the "Add team members" modal.