Skip to content

Fix: Hide *Delete* action for read-only address books #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hamza221 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix: Hide *Delete* action for read-only address books #3388

hamza221 wants to merge 1 commit into from

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented May 16, 2023

Fixes #3383

@hamza221
Fix: Hide *Delete* action for read-only address books
fa78419 
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels May 16, 2023
@hamza221 hamza221 self-assigned this May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.83 ⚠️

Comparison is base (97c1fcc) 1.82% compared to head (c41ef8e) 0.00%.

❗ Current head c41ef8e differs from pull request most recent head fa78419. Consider uploading reports for the commit fa78419 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##              main   #3388      +/-   ##
==========================================
- Coverage     1.82%   0.00%   -1.83%     
  Complexity     272     272              
==========================================
  Files          112      25      -87     
  Lines         6075     824    -5251     
  Branches      1445       0    -1445     
==========================================
- Hits           111       0     -111     
+ Misses        5849     824    -5025     
+ Partials       115       0     -115

see 87 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hamza221 hamza221 requested a review from ChristophWurst May 18, 2023 14:08
ChristophWurst
ChristophWurst reviewed May 18, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ABs can be shared read-only too. Then the collection should be deletable to allow unsharing.

We have to check if the AB is not shared but ro

@hamza221 hamza221 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 31, 2023
@st3iny st3iny marked this pull request as draft August 21, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov will be requested when the pull request is marked ready for review GVodyanov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@hamza221 hamza221

Labels

2. developing Work in progress bug Something isn't working skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hide *Delete* action for read-only address books

3 participants

@hamza221 @ChristophWurst