Skip to content

Enh/social sync #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Fix communication of enabled/disabled addressbook (#1927)
merged 1 commit into from
Jul 25, 2020
Merged

Enh/social sync #1692

merged 1 commit into from
Jul 25, 2020

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 10, 2020 •
edited
Loading

closes #1580

@skjnldsv skjnldsv requested a review from call-me-matt July 10, 2020 07:36
@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement New feature or request labels Jul 10, 2020
@skjnldsv skjnldsv mentioned this pull request Jul 10, 2020
Closed
@codecov

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv force-pushed the enh/social-sync branch 2 times, most recently from f7b2fc4 to 8558eec Compare July 10, 2020 07:44
@call-me-matt call-me-matt mentioned this pull request Jul 10, 2020
Closed
@skjnldsv skjnldsv force-pushed the enh/social-sync branch 2 times, most recently from ec4a7ca to 615bfa9 Compare July 14, 2020 08:53
skjnldsv
skjnldsv commented Jul 14, 2020
View reviewed changes
Copy link
Member Author

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works™ 😉

skjnldsv
skjnldsv commented Jul 14, 2020
View reviewed changes
call-me-matt
call-me-matt approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@call-me-matt call-me-matt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Can't wait to have it integrated.

@call-me-matt call-me-matt force-pushed the enh/social-sync branch 2 times, most recently from c4226aa to 22584de Compare July 16, 2020 22:18
@call-me-matt
Copy link
Member

I enhanced the facebook provider with a function to determine the numeric id if only the user name is given. It's not very reliable, but better than nothing, I'd say.

@skjnldsv
Copy link
Member Author

@call-me-matt please run composer run cs:fix and let get this merged :)

@call-me-matt call-me-matt force-pushed the enh/social-sync branch 2 times, most recently from a9232db to 43f3e64 Compare July 22, 2020 05:54
@skjnldsv
Allow for avatar downloads from social networks
e84571f 
Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
@skjnldsv skjnldsv added this to the next minor milestone Jul 25, 2020
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 25, 2020
@call-me-matt call-me-matt merged commit 7096151 into master Jul 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the enh/social-sync branch July 25, 2020 07:56
@skjnldsv
Copy link
Member Author

Congrats! 🚀 🎉

MorrisJobke
MorrisJobke reviewed Aug 11, 2020
View reviewed changes
@skjnldsv skjnldsv modified the milestones: next minor, next Sep 6, 2020
@skjnldsv skjnldsv modified the milestones: next, 3.4.0 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke left review comments

@call-me-matt call-me-matt call-me-matt approved these changes

Assignees

@skjnldsv skjnldsv

@call-me-matt call-me-matt

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @call-me-matt @MorrisJobke