Skip to content

chore(cy): fix cypress test #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 2 commits into from
Sep 8, 2025
Merged

chore(cy): fix cypress test #1954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4313eeb
chore(cy): drop one level of describe / indentation
max-nextcloud Sep 1, 2025
37c9687
chore(cy): check for page name
max-nextcloud Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
231 changes: 115 additions & 116 deletions cypress/e2e/collective-share.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,123 +11,122 @@ describe('Collective Share', function() {
cy.deleteAndSeedCollective('Share me')
})

describe('collective share', function() {
it('Allows sharing a collective', function() {
cy.loginAs('bob')
cy.visit('/apps/collectives', {
onBeforeLoad(win) {
// navigator.clipboard doesn't exist on HTTP requests (in CI), so let's create it
if (!win.navigator.clipboard) {
win.navigator.clipboard = {
__proto__: {
writeText: () => {},
},
}
it('Allows sharing a collective', function() {
cy.loginAs('bob')
cy.visit('/apps/collectives', {
onBeforeLoad(win) {
// navigator.clipboard doesn't exist on HTTP requests (in CI), so let's create it
if (!win.navigator.clipboard) {
win.navigator.clipboard = {
__proto__: {
writeText: () => {},
},
}
// overwrite navigator.clipboard.writeText with cypress stub
cy.stub(win.navigator.clipboard, 'writeText', (text) => {
shareUrl = text
})
.as('clipBoardWriteText')
},
})
cy.openCollectiveMenu('Share me')
cy.clickMenuButton('Share link')
cy.intercept('POST', '**/api/v1.0/collectives/*/shares').as('createShare')
cy.get('.sharing-entry button.new-share-link')
.click()
cy.wait('@createShare')
cy.get('.toast-success').should('contain', 'Collective "Share me" has been shared')
cy.get('.sharing-entry .share-select')
.should('contain', 'View only')
cy.get('button.sharing-entry__copy')
.click()
cy.get('.toast-success').should('contain', 'Link copied')
cy.get('@clipBoardWriteText').should('have.been.calledOnce')
})
it('Allows opening a shared (non-editable) collective', function() {
cy.logout()
cy.visit(shareUrl)
cy.get('[data-cy-collectives="page-title-container"] input').should('have.value', 'Share me')
cy.get('button.titleform-button').should('not.exist')
cy.getReadOnlyEditor()
.find('h1').should('contain', 'Welcome to your new collective')
cy.get('.app-content-list-item.toplevel')
.find('button.icon.add')
.should('not.exist')
cy.getEditor().should('not.exist')
})
it('Allows setting a collective share to editable', function() {
cy.loginAs('bob')
cy.visit('apps/collectives')
cy.openCollectiveMenu('Share me')
cy.clickMenuButton('Share link')
cy.get('.sharing-entry .share-select')
.click()
cy.intercept('PUT', '**/api/v1.0/collectives/*/shares/*').as('updateShare')
cy.get('.sharing-entry .share-select .dropdown-item')
.contains('Can edit')
.click()
cy.wait('@updateShare')
cy.get('.toast-success').should('contain', 'Share link of collective "Share me" has been updated')
cy.get('.sharing-entry .share-select')
.should('contain', 'Can edit')
})
it('Allows opening and editing a shared (editable) collective', function() {
cy.logout()
cy.visit(shareUrl)
// Do some handstands to ensure that new page with editor is loaded before we edit the title
cy.intercept('POST', '**/api/v1.0/p/collectives/*/pages/*').as('createPage')
cy.intercept('PUT', '**/apps/text/public/session/*/create').as('textCreateSession')
cy.contains('.app-content-list-item', 'Share me')
.find('button.action-button-add')
.click()
cy.wait(['@createPage', '@textCreateSession'])
cy.getEditor()
.should('be.visible')
cy.get('[data-cy-collectives="page-title-container"] input.title')
.should('not.have.attr', 'disabled')
cy.get('[data-cy-collectives="page-title-container"] input.title')
.should('have.value', '')
cy.get('[data-cy-collectives="page-title-container"] input.title')
.type('New page')
cy.getEditorContent(true)
.type('New content')
cy.get('button.titleform-button')
.click()
})
it('Allows using the page list filter', function() {
cy.logout()
cy.visit(shareUrl)
cy.intercept('GET', '**/api/v1.0/p/collectives/*/search?**').as('searchCollective')
cy.get('input[name="pageFilter"]')
.type('page')
cy.wait('@searchCollective')
cy.get('.app-content-list-item-line-one:visible').should('have.length', 2)
cy.get('.app-content-list-item-line-one:visible').eq(0)
.should('contain', 'Share me')
cy.get('.app-content-list-item-line-one:visible').eq(1)
.should('contain', 'New page')
cy.get('.search-dialog-container')
.should('be.visible')
})
it('Allows unsharing a collective', function() {
cy.loginAs('bob')
cy.visit('apps/collectives')
cy.openCollectiveMenu('Share me')
cy.clickMenuButton('Share link')
cy.get('.sharing-entry__actions')
.click()
cy.intercept('DELETE', '**/api/v1.0/collectives/*/shares/*').as('deleteShare')
cy.get('.unshare-button')
.click()
cy.wait('@deleteShare')
cy.get('.toast-success').should('contain', 'Collective "Share me" has been unshared')
})
it('Opening unshared collective fails', function() {
cy.logout()
cy.visit(shareUrl, { failOnStatusCode: false })
cy.get('.body-login-container').contains(/(File|Page|Share) not found/)
}
// overwrite navigator.clipboard.writeText with cypress stub
cy.stub(win.navigator.clipboard, 'writeText', (text) => {
shareUrl = text
})
.as('clipBoardWriteText')
},
})
cy.openCollectiveMenu('Share me')
cy.clickMenuButton('Share link')
cy.intercept('POST', '**/api/v1.0/collectives/*/shares').as('createShare')
cy.get('.sharing-entry button.new-share-link')
.click()
cy.wait('@createShare')
cy.get('.toast-success').should('contain', 'Collective "Share me" has been shared')
cy.get('.sharing-entry .share-select')
.should('contain', 'View only')
cy.get('button.sharing-entry__copy')
.click()
cy.get('.toast-success').should('contain', 'Link copied')
cy.get('@clipBoardWriteText').should('have.been.calledOnce')
})
it('Allows opening a shared (non-editable) collective', function() {
cy.logout()
cy.visit(shareUrl)
cy.get('[data-cy-collectives="page-title-container"] input').should('have.value', 'Share me')
cy.get('button.titleform-button').should('not.exist')
cy.getReadOnlyEditor()
.find('h1').should('contain', 'Welcome to your new collective')
cy.get('.app-content-list-item.toplevel')
.find('button.icon.add')
.should('not.exist')
cy.getEditor().should('not.exist')
})
it('Allows setting a collective share to editable', function() {
cy.loginAs('bob')
cy.visit('apps/collectives')
cy.openCollectiveMenu('Share me')
cy.clickMenuButton('Share link')
cy.get('.sharing-entry .share-select')
.click()
cy.intercept('PUT', '**/api/v1.0/collectives/*/shares/*').as('updateShare')
cy.get('.sharing-entry .share-select .dropdown-item')
.contains('Can edit')
.click()
cy.wait('@updateShare')
cy.get('.toast-success').should('contain', 'Share link of collective "Share me" has been updated')
cy.get('.sharing-entry .share-select')
.should('contain', 'Can edit')
})
it('Allows opening and editing a shared (editable) collective', function() {
cy.logout()
cy.visit(shareUrl)
// Do some handstands to ensure that new page with editor is loaded before we edit the title
cy.intercept('POST', '**/api/v1.0/p/collectives/*/pages/*').as('createPage')
cy.intercept('PUT', '**/apps/text/public/session/*/create').as('textCreateSession')
cy.contains('.app-content-list-item', 'Share me')
.find('button.action-button-add')
.click()
cy.wait(['@createPage', '@textCreateSession'])
cy.getEditor()
.should('be.visible')
cy.get('[data-cy-collectives="page-title-container"] input.title')
.should('not.have.attr', 'disabled')
cy.get('[data-cy-collectives="page-title-container"] input.title')
.should('have.value', '')
cy.get('[data-cy-collectives="page-title-container"] input.title')
.type('New page{enter}')
cy.getEditorContent(true)
.type('New content')
cy.get('button.titleform-button')
.click()
cy.contains('.app-content-list-item a', 'New page')
})
it('Allows using the page list filter', function() {
cy.logout()
cy.visit(shareUrl)
cy.intercept('GET', '**/api/v1.0/p/collectives/*/search?**').as('searchCollective')
cy.get('input[name="pageFilter"]')
.type('page')
cy.wait('@searchCollective')
cy.get('.app-content-list-item-line-one:visible').should('have.length', 2)
cy.get('.app-content-list-item-line-one:visible').eq(0)
.should('contain', 'Share me')
cy.get('.app-content-list-item-line-one:visible').eq(1)
.should('contain', 'New page')
cy.get('.search-dialog-container')
.should('be.visible')
})
it('Allows unsharing a collective', function() {
cy.loginAs('bob')
cy.visit('apps/collectives')
cy.openCollectiveMenu('Share me')
cy.clickMenuButton('Share link')
cy.get('.sharing-entry__actions')
.click()
cy.intercept('DELETE', '**/api/v1.0/collectives/*/shares/*').as('deleteShare')
cy.get('.unshare-button')
.click()
cy.wait('@deleteShare')
cy.get('.toast-success').should('contain', 'Collective "Share me" has been unshared')
})
it('Opening unshared collective fails', function() {
cy.logout()
cy.visit(shareUrl, { failOnStatusCode: false })
cy.get('.body-login-container').contains(/(File|Page|Share) not found/)
})
})
Loading