Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove fully_qualified_strict_types again #16

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

nickvergessen
Copy link
Member

fully_qualified_strict_types => leading_backslash_in_global_namespace we want to use was only introduced with 3.46 PHP-CS-Fixer/PHP-CS-Fixer@0061223

@nickvergessen nickvergessen self-assigned this Feb 1, 2024
@nickvergessen
Copy link
Member Author

come-nc
come-nc previously approved these changes Feb 1, 2024
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New minor release with changelog line?

composer.json Outdated Show resolved Hide resolved
ChristophWurst
ChristophWurst previously approved these changes Feb 1, 2024
nickvergessen and others added 2 commits February 1, 2024 15:38
There are currently too many issues for the rule on the project itself
#17
PHP-CS-Fixer/PHP-CS-Fixer#7719

Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

As per #17 we remove the rule for now again instead

@nickvergessen nickvergessen changed the title Update required cs-fixer version fix: Remove fully_qualified_strict_types again Feb 1, 2024
@come-nc
Copy link
Contributor

come-nc commented Feb 1, 2024

We may still want to update php-cs-fixer?

@nickvergessen
Copy link
Member Author

We may still want to update php-cs-fixer?

It's not required anymore, so I prefer to not break things :-X

@nickvergessen nickvergessen merged commit cf5f18d into master Feb 1, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nickvergessen-patch-1 branch February 1, 2024 14:54
@come-nc
Copy link
Contributor

come-nc commented Feb 1, 2024

We may still want to update php-cs-fixer?

It's not required anymore, so I prefer to not break things :-X

Yeah but then you’re not fixing things either

@nickvergessen
Copy link
Member Author

Yeah but then you’re not fixing things either

No need to fix something that is not broken.

We can make a new version/branch with 2.0 requiring 8.0 and cs-fixer 3.48+ or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants