- 
                Notifications
    You must be signed in to change notification settings 
- Fork 44
Upstream/pico3 #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            derMart
  wants to merge
  6
  commits into
  nextcloud:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
derMart:upstream/pico3
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            Upstream/pico3 #232
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    add7692    to
    eb9bffc      
    Compare
  
    | API_VERSION_4 also needs to be added here: | 
96d7b66    to
    cad6e18      
    Compare
  
    | @harrysummer thanks alot! I've added the change | 
Signed-off-by: derMart <derMart@users.noreply.github.com>
Signed-off-by: derMart <derMart@users.noreply.github.com>
Signed-off-by: derMart <derMart@users.noreply.github.com>
Signed-off-by: derMart <derMart@users.noreply.github.com>
$ composer update picocms/pico picocms/pico-theme picocms/pico-deprecated -W Loading "picocms/composer-installer" which is a legacy composer-installer built for Composer 1.x, it is likely to cause issues as you are running Composer 2.x. Composer is operating significantly slower than normal because you do not have the PHP curl extension enabled. Loading composer repositories with package information Info from https://repo.packagist.org: #StandWithUkraine Updating dependencies Lock file operations: 1 install, 7 updates, 4 removals - Removing incompass/coverage (1.0.0) - Removing psr/log (1.1.4) - Removing symfony/console (v3.4.47) - Removing symfony/debug (v4.4.44) - Downgrading erusev/parsedown (1.8.0-beta-7 => 1.7.4) - Upgrading erusev/parsedown-extra (0.8.0-beta-1 => 0.8.1) - Upgrading picocms/pico (v2.1.4 => dev-pico-3.0 efa51f6) - Upgrading picocms/pico-deprecated (v2.1.4 => dev-pico-3.0 38c788d) - Upgrading picocms/pico-theme (v2.1.4 => dev-pico-3.0 b648e93) - Locking symfony/deprecation-contracts (v3.2.1) - Upgrading symfony/yaml (v2.8.52 => v5.4.21) - Upgrading twig/twig (v1.44.7 => v3.5.1) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 0 installs, 2 updates, 0 removals - Downloading symfony/deprecation-contracts (v3.2.1) - Downloading symfony/yaml (v5.4.21) - Upgrading symfony/deprecation-contracts (v3.2.0 => v3.2.1): Extracting archive - Upgrading symfony/yaml (v5.4.19 => v5.4.21): Extracting archive Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested. Generating autoload files > Pico\Composer\Installer\PluginInstaller::postAutoloadDump Updating Pico plugins file Signed-off-by: derMart <derMart@users.noreply.github.com>
Signed-off-by: derMart <derMart@users.noreply.github.com>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
As discussed in #218 here is a pull request to upstream to Pico 3.
I had to remove
incompass/coveragecomposer package as this was causing incompatibilities with current symfony packages. Maybe an alternative need to be found for this. However, as I did not get tests to execute anyway (see #231) this might be fixed in the future anyway.